New test for diagnostics on model levels. #69
Conversation
driver/plot_test_outputs.py
Outdated
| 'xaxis_type': 'latitude', | ||
| 'yaxis_type': x.dimensions[0]} | ||
| except: | ||
| print("Variable not processed: {}".format(vname)) |
There was a problem hiding this comment.
Love the exception - maybe a more informative message?
driver/src/cosp2_test.f90
Outdated
| @@ -549,7 +548,7 @@ subroutine subsample_and_optics(nPoints, nLevels, nColumns, nHydro, overlap, | |||
| mr_ccice,dtau_c,dtau_s,dem_c,dem_s,fl_lsrainIN,fl_lssnowIN,fl_lsgrplIN,fl_ccrainIN,& | |||
| fl_ccsnowIN | |||
| real(wp),intent(in),dimension(nPoints,nLevels,nHydro) :: reffIN | |||
| logical,intent(in) :: use_precipitation_fluxes | |||
| logical,intent(in) :: use_vgrid, use_precipitation_fluxes | |||
There was a problem hiding this comment.
Could you add a comment here explaining what this means?
There was a problem hiding this comment.
use_vgrid controls the use of model levels (.false.) or an evenly-spaced (.true.) vertical grid for outputs.
@RobertPincus did you mean 'here' in the discussion or a comment in the code itself?
There was a problem hiding this comment.
@alejandrobodas I meant a comment in the code itself, as use_vgrid is maybe less obviously clear than say use_precipitation_fluxes
There was a problem hiding this comment.
@RobertPincus I see, I've added comment as requested.
|
@alejandrobodas This looks great, I have a few small suggestions. |
|
@dustinswales @RobertPincus thanks for your reviews. I've addressed Robert's comments, so I think this is ready for merging. I'll merge it sometime tomorrow unless I hear from you otherwise. |
This PR addresses #68 . It implements a test that sets use_vgrid=.false. It uses the UM global inputs. The test is only run for the 'gfortran' compiler, to avoid overloading the battery of tests.