Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default mathjax URL for doxygen 1.8.13 #3135

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Fix default mathjax URL for doxygen 1.8.13 #3135

merged 1 commit into from
Jun 1, 2018

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented May 30, 2018

Fixes #3134

@sloriot sloriot added the Doc label May 30, 2018
@sloriot sloriot added this to the 4.12.1 milestone May 30, 2018
@lrineau lrineau self-assigned this May 30, 2018
@lrineau lrineau added Ready to be tested Under Testing rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch Tested rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' and removed Under Testing labels May 30, 2018
@lrineau lrineau merged commit a0017d8 into CGAL:releases/CGAL-4.12-branch Jun 1, 2018
lrineau added a commit that referenced this pull request Jun 1, 2018
@lrineau
Merge pull request #3135 from sloriot/Doc-mathjax_1.8.13
bcdd908 
Fix default mathjax URL for doxygen 1.8.13
lrineau added a commit that referenced this pull request Jun 1, 2018
@lrineau
Merge pull request #3135 from sloriot/Doc-mathjax_1.8.13
3bb8913 
Fix default mathjax URL for doxygen 1.8.13
@lrineau lrineau removed Ready to be tested rm only: ready for release branch For the release team only: that indicates that a PR is about to be merged in a release branch labels Jun 1, 2018
@lrineau
Copy link
Member

lrineau commented Jun 4, 2018

Successfully tested in CGAL-4.13-Ic-26, and then merged.

@lrineau lrineau deleted the Doc-mathjax_1.8.13 branch June 4, 2018 08:50
@lrineau
Copy link
Member

lrineau commented Jun 4, 2018

@sgiraudot The default path of MathJax, for Doxygen 1.8.13, is now fixed, in master. If you have an any way to test that, a confirmation of the fix would be nice.

@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 4, 2018
@sgiraudot
Copy link
Contributor

sgiraudot commented Jun 11, 2018 •
edited
Loading

I compiled the doc of master with 1.8.13 and uploaded a few packages to my directory on the GF server, the formulas look good. So this PR indeed fixed the problem. All good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lrineau lrineau

Labels
Doc Merged_in_4.12.1 Merged_in_4.12.2 Merged_in_4.13 Tested
Projects
None yet
Milestone
4.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sloriot @lrineau @sgiraudot