[WIP] CGAL 3D constrained Delaunay triangulation #8186
Draft
+91,486
−967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` 2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.' 2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled 2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled ```
There was a warning: ``` Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=] [build] 1841 | } // dim 2 [build] | ^ ``` and for once that was a warning about a real bug!
The files are even repaired on the fiy.
For the moment, I selected: - num_vertices < 10000 and - "solid" As for the meaning of "solid", quoting Zhou, Qingnan, et al. "Mesh arrangements for solid geometry." ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.: > Solid meshes are free of self-intersections, degenerate triangles > or duplicate triangles, and their generalized winding number field > is either zero or one.
... instead of applying random selection of buckets.
`Surface_mesh::collect_garbage` uses swaps, and this it modifies the order of elements of the mesh.
@MaelRL This is the bug of Saddle-1CC.
so that I can introduce new ones more easily
this one is to dump the input surface with the extra Steiner points of the conforming. And add a --help option as well.
Check that the triangulation is still Delaunay after the conforming.
that will allows its reuse by the function `insert(Point)`
- make it const, - and simplify the reuse of the API.
(but the debug outputs)
*Immediately Invoked Lambda Expression* Now that CGAL can use C++17 , switch to `std::invoke` that is more readable that the two small characters `()` hidden somewhere a few lines below. With `std::invoke`, we understand straight away that the lambda is called immediately. Ref: https://www.cppstories.com/2016/11/iife-for-complex-initialization/
If the output iterator is a function-output-iterator, then the cell is already correctly constructed. Also, rename `fit` to `cit`
…on_3-CDT_3-lrineau
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Doc prototype: |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/build:wip_v2 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8186/wip_v2/Manual/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Doc prototype:
This is a work in progress for now. Stay tuned...
TODO list
Release Management