Work in progress on CDT_3 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
2 times, most recently
from
8812cab
to
6d33336
Compare
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
from
02decc6
to
b209dcd
Compare
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
3 times, most recently
from
1e92afc
to
6600d8d
Compare
lrineau
force-pushed
the
master
branch
3 times, most recently
from
a6d3e97
to
00a7a32
Compare
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
from
97faa77
to
b9447a9
Compare
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
from
1c0a084
to
1be8e68
Compare
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
2 times, most recently
from
54d0b48
to
5e9570c
Compare
``` 2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.' 2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled 2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled ```
There was a warning: ``` Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=] [build] 1841 | } // dim 2 [build] | ^ ``` and for once that was a warning about a real bug!
The files are even repaired on the fiy.
For the moment, I selected: - num_vertices < 10000 and - "solid" As for the meaning of "solid", quoting Zhou, Qingnan, et al. "Mesh arrangements for solid geometry." ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.: > Solid meshes are free of self-intersections, degenerate triangles > or duplicate triangles, and their generalized winding number field > is either zero or one.
... instead of applying random selection of buckets.
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
from
3b266f5
to
4829813
Compare
`Surface_mesh::collect_garbage` uses swaps, and this it modifies the order of elements of the mesh.
@MaelRL This is the bug of Saddle-1CC.
that avoids code like `o_vt_f_pair.second.first` Backport: master
*Immediately Invoked Lambda Expression* Now that CGAL can use C++17 , switch to `std::invoke` that is more readable that the two small characters `()` hidden somewhere a few lines below. With `std::invoke`, we understand straight away that the lambda is called immediately. Ref: https://www.cppstories.com/2016/11/iife-for-complex-initialization/
If the output iterator is a function-output-iterator, then the cell is already correctly constructed. Also, rename `fit` to `cit`
…on_3-CDT_3-lrineau
lrineau
force-pushed
the
Triangulation_3-CDT_3-lrineau
branch
from
96b01ec
to
69b6de3
Compare
|
See CGAL#8186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.