Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mermaid): adds a tab to visualize a mermaid graph of the masking #159

Merged
merged 9 commits into from
Aug 16, 2022

Conversation

CapKicklee
Copy link
Collaborator

Adds a tab to visualize a mermaid graph of the masking

@CapKicklee CapKicklee linked an issue Aug 4, 2022 that may be closed by this pull request
@adrienaury
Copy link
Member

error An unexpected error occurred: "http://artefact-repo.pole-emploi.intra:80/artifactory/api/npm/npm-public/lz-string/-/lz-string-1.4.4.tgz: getaddrinfo ENOTFOUND artefact-repo.pole-emploi.intra".

Delete package-lock.json pushed inadvertently
@CapKicklee
Copy link
Collaborator Author

Does the deletion of package-lock.json fix the issue?

@CapKicklee
Copy link
Collaborator Author

Does the deletion of package-lock.json fix the issue?

Looks like it was the yarn.lock, I restored it to its initial state (did not change anything, so it was pointless to keep it)

@adrienaury
Copy link
Member

When i try it, i get this error : TypeError: n is not a function
Also, it doesnt seem to work properly on all examples

@adrienaury
Copy link
Member

Some charts are unreadeable because we can't zoom in or out..
I think this zoom feature example should be relatively easy to adapt to our case.

@CapKicklee
Copy link
Collaborator Author

Some charts are unreadeable because we can't zoom in or out.. I think this zoom feature example should be relatively easy to adapt to our case.

Thanks for sharing, I added it, and it should be more readable now

When i try it, i get this error : TypeError: n is not a function Also, it doesnt seem to work properly on all examples

Yes, I had some troubles with the use of mermaidAPI, but I found a workaround and it should be fixed now.
Do you have any example not providing the result you'd expect?

youen
youen previously approved these changes Aug 16, 2022
@youen youen merged commit 4fce58d into main Aug 16, 2022
@youen youen deleted the 154-proposal-pimo-play-add-mermaid-view branch August 16, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] PIMO PLAY Add mermaid view
3 participants