Skip to content

Commit

Permalink
Merge pull request #172 from ngourdeau/master
Browse files Browse the repository at this point in the history 
Fix package URL for PHP 5.3.8
  • Loading branch information
@CHH
CHH committed Jan 28, 2014
2 parents f85e5f1 + 70fdf55 commit 226802e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion share/php-build/definitions/5.3.8
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
install_package "http://www.php.net/distributions/php-5.3.8.tar.bz2"
install_package "http://museum.php.net/php5/php-5.3.8.tar.bz2"
install_pyrus
install_xdebug "2.2.0"

10 comments on commit 226802e

@gerardroche
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this url need changing? Do all the other definitions need updating too?

@CHH
Copy link
Member Author

@CHH CHH commented on 226802e Jan 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there is any kind of process behind this, but the php.net team puts old PHP tarballs to the museum site after some time and removes them from php.net/distributions.

It's ridiculous that they intentionally break their public URLs.

@gerardroche
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using the php-src github repository tarballs.

Note that the github tagged releases are slightly different than the downloads on the php.net. The release process on line 81 says to run the script ./makedist.

Nice thing about using the tags is that they won't change, and github is https too.

@rogeriopradoj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing discussion #175.

@bjori
Copy link

@bjori bjori commented on 226802e Feb 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CHH I'd like to note that /distributions/ is intentionally not a public link and is not announced anywhere.
The actual public links could fairly easily be redirected to museum when needed - as long as you actually use the public links - but there has never been a need for it, making the time maintainence and implementation time not worth it

@rogeriopradoj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjori thanks for joining the conversation.

Could you point us with the path to php repos where this redirection could be done? Perhaps someone could take a look and try to implement it based on this.

@bjori
Copy link

@bjori bjori commented on 226802e Feb 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogeriopradoj https://github.com/php/web-php/blob/master/error.php#L142
If the file does not exist on the server, then a check of the release history can be done (https://github.com/php/web-php/blob/master/include/releases.inc) and if "museum" is true, then replace the mirror listing with the museum link (for /from/a/mirror urls), or redirected (for /from/museum.php.net/mirror url)

@rogeriopradoj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had implemented a very simplified version (before seeing your answer).

https://gist.github.com/rogeriopradoj/9025851 (one pretty bad thing there is that it is relying on not public links as you already note on us).

I will dive into the links you provided, too see how we could make it good for CHH/php-build and maybe php internals as well :-).

Thanks again!

@bjori
Copy link

@bjori bjori commented on 226802e Feb 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.
But please make sure you mail the appropriate mailinglist. This has nothing to do with internals@ so will not lead to anything productive if you use that list. The appropriate discussion list is php-webmaster@lists.php.net - see http://php.net/mailinglists

@CHH
Copy link
Member Author

@CHH CHH commented on 226802e Feb 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @bjori! 😃

Please sign in to comment.