Update scripts, code, tests to fix handful of issues including parse namelist checking #215
Conversation
|
I am running the test suite now and will have results shortly. |
|
The atan2 seems to just be an issue on hobart with nag. It has been a problem for a while, we just hadn't addressed it. I am not happy about adding it, but it seems to help some of the test results on hobart. It should not be needed. |
| atm_data_format = 'bin' | ||
| atm_data_dir = '/glade/u/home/tcraig/cice_data/' |
There was a problem hiding this comment.
Should this really point to your directory, @apcraig ?
ICE_MACHINE_INPUTDATA/CICE_data/ might be better.
There was a problem hiding this comment.
I noticed that too. It's been that way for a while. I'll fix it sometime. It's always overridden so I don't think it's a problem. But I agree better to have something more generic there.
|
Tests look good, hash 47507fb here https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks. Also, I just made one small commit to allow for longer run times for a couple tests, so will wait for travis to pass then merge this PR. |
|
If someone could approve this again, that would be great. I cannot do it and cannot merge until I have a review. |
Update scripts, code, tests to implement a few important features
Developer(s): tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit
Does this PR create or have dependencies on Icepack or any other models? N
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately at a later time? (Y/N) N
Other Relevant Details:
Add check that namelist parsing strings are valid and in ice_in.
Workaround atan2 bug on nag on hobart.
Update poll_queue script to catch all jobs, stopped working correctly when executable reuse was introduced.
Turn off some questionable OMP loops.
Fix OMP loop in ice_restart_driver.
Update set_nml.gx1, turn off ocn_data again.
Add qstat env variable for hobart.
Add workaround for ice_distribution clean for unallocated datatype variables.
Add new diagnostic to report_results associated with non-fail, non-pass test info and set default test result to FAIL.