Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack interfaces consistent with recent changes in Icepack #379

Merged
merged 6 commits into from Dec 8, 2019
Merged

Update Icepack interfaces consistent with recent changes in Icepack #379

merged 6 commits into from Dec 8, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Nov 24, 2019

DO NOT MERGE THIS

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack interfaces to show how recent change affect CICE
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

This provides a opportunity to review how recent changes in the Icepack interfaces affect CICE. See CICE-Consortium/Icepack#285

@apcraig apcraig mentioned this pull request Nov 24, 2019
Merged
16 tasks
@apcraig
remove n_aero from icepack therm1 and therm2 arguments
abaaa5e 
migrate use of non icepack_intfc to icepack_intfc
rename some icepack mushy routines to meet naming convention
works with icepack #96970594235d81b
@apcraig
Merge branch 'master' of https://github.com/cice-consortium/cice into…
6049eaf 
… optarg2
@apcraig
update interface call
ac1757d
@apcraig
update icepack and update CICE version number to 6.1
926c9ab
@apcraig apcraig merged commit d964a74 into CICE-Consortium:master Dec 8, 2019
@apcraig apcraig deleted the optarg2 branch August 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 Awaiting requested review from eclare108213

@phil-blain phil-blain Awaiting requested review from phil-blain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@apcraig