Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update io_pio and io_pio2 for fsd input and output fields #444

Merged
merged 1 commit into from May 15, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 13, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update io_pio and io_pio2 to handle fsd fields
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    This was tested in RASM with io_pio. io_pio2 was copied from io_pio and then the pio_setframe call was updated. io_pio2 has not been tested. Standalone CICE testing does not test this code at the present time. Testing of the io_pio and io_pio2 code is inadequate. See further comments below.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Addresses #443.

Also related to #246.

This could be merged now, but depending on status of #246, we may want to do #246 first, with, or after this PR.

@dabail10
Copy link
Contributor

I was about to email you with this. There are a couple issues. The interfaces for io_pio and io_pio2 are different for standalone and coupled. So, do we ifdef what we need here? Also, I can't figure out why it is not finding the subroutine pio_init. I'll email offline.

@apcraig
Copy link
Contributor Author

apcraig commented May 15, 2020

I'm going to merge this at this only affects pio code. We need this code to address some failures in #246.

@apcraig apcraig merged commit bce31c2 into CICE-Consortium:master May 15, 2020
@apcraig apcraig deleted the piofsd branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants