Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timeseries plots to resolve issue with some fields #539

Conversation

mattdturner
Copy link
Contributor

PR checklist

  • Short (1 sentence) summary of your PR:
    Update the 2 timeseries plotting scripts to accurately extract the data from log files.
  • Developer(s):
    @mattdturner
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    N/A. This only touches the plotting scripts, not the model code.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
  1. Update the 2 timeseries plotting scripts to accurately extract the data from log files.
  2. Also add an option to plot SST from the python plotting script.
  3. This addresses issue timeseries plotting errors #538

…. Also add an option to plot SST from the python plotting script. This addresses issue CICE-Consortium#538
@mattdturner
Copy link
Contributor Author

@eclare108213 This should address the plotting issues you were having in #538 . I will need to create a separate PR to allow users to pass variable names as arguments, once I figure out a good way to implement it.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two typos in timeseries.csh - this is a good time to fix them:

  1. change Manuallyl to Manually
  2. change alis to axis

Otherwise this works for me! thanks much.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattdturner - one more thought -
To not change the functionality too much at this point, it would be better to not include the sst and arwt tot mass in the timeseries list, for this merge. They can be included for plotting once you've figured out a more general implementation (which isn't a super high priority). Sound okay?

@eclare108213
Copy link
Contributor

Thank you @mattdturner ! I'll merge this when the checks finish.

@mattdturner
Copy link
Contributor Author

@eclare108213 That sounds good to me. I went ahead and removed those variables from the list and pushed a new commit.

@apcraig apcraig added the Tools label Dec 7, 2020
@eclare108213 eclare108213 self-assigned this Dec 7, 2020
@eclare108213 eclare108213 added this to In progress in CICE v6.1.4 via automation Dec 7, 2020
@eclare108213 eclare108213 merged commit 40d3867 into CICE-Consortium:master Dec 7, 2020
CICE v6.1.4 automation moved this from In progress to Done Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CICE v6.1.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants