Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDC-1429 CIDC-1422 bump API for ctDNA string values, actually apply all permissions on upload #723

Merged
merged 2 commits into from Aug 15, 2022

Conversation

scvannost
Copy link
Collaborator

Parallels:

What

  • Bump schemas
    • Add possibility for string values to some ctdna analysis columns for null values
  • Include cross-trial and cross-assay permissions when implementing them for a new upload job
    • wasn't including any permission where either trial_id or upload_type was null

Why

  • Schemas: 10047 ctdna analysis contains null values
  • If not applied at upload, then need to reclick or pubsub-trigger afterwards to implement correct permissions on new files.
    Not necessarily the only source of this issue, but definitely contributes

How

  • Switch from filter_by kwarg filtering to filter hybrid property filtering.

Remarks

  • Don't include cross-assay ie upload_type null if the upload is clincal_data
  • Always include trial_id null
  • Added both cross-trial and cross-assay permissions to test of updated functions
  • Also added missing grant_lister_permission call for each user

Checklist

Please include and complete the following checklist. You can mark an item as complete with the - [x] prefix:

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions
  • Documentation - README and CHANGELOG have been updated to explain major changes & new features
  • Package version - Manually bumped the API package version in init.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants