Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gs:// prefix to ls #138

Merged
merged 2 commits into from May 11, 2021
Merged

Add gs:// prefix to ls #138

merged 2 commits into from May 11, 2021

Conversation

scvannost
Copy link
Contributor

No description provided.

jacoblurye
jacoblurye approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@jacoblurye jacoblurye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to update the tests to illustrate the bug and show that it's now fixed?

@scvannost scvannost merged commit 1cf5e7d into master May 11, 2021
@roshni-b roshni-b deleted the gs-buckets branch May 13, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roshni-b roshni-b roshni-b approved these changes

@jacoblurye jacoblurye jacoblurye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scvannost @roshni-b @jacoblurye