Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUHN check on credit cards #447

Closed
syloktools opened this issue Dec 23, 2019 · 3 comments
Closed

LUHN check on credit cards #447

syloktools opened this issue Dec 23, 2019 · 3 comments

Comments

@syloktools
Copy link

Can a luhn check be added to validate credit card numbers?

https://pypi.org/project/fast-luhn/
@adulau
Copy link
Member

adulau commented Dec 23, 2019

I thought we do it there

AIL-framework/bin/CreditCards.py

Line 68 in ecd14b9

if lib_refine.is_luhn_valid(clean_card):

Do you have any specific issues?

@syloktools
Copy link
Author

I have seen some invalid card such as 4777777777777777

Terrtia added a commit that referenced this issue Jan 9, 2020
@Terrtia
fix: [UI term] remove deprecated trending charts, fix #446 #447
91ce045
@Terrtia
Copy link
Member

Terrtia commented Jan 9, 2020

Hi @robertnixon2003 !

I did some test and didn't find any issue with your Luhn implementation,
4777777777777777 is not detected as a valid credit-card

Can you share a sample of one of your false positive ?

@Terrtia Terrtia closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adulau @Terrtia @syloktools