Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex to disregard locked accounts #371

Merged
merged 1 commit into from Mar 27, 2017

Conversation

pyllyukko
Copy link
Contributor

This way, accounts that have ":!!:" in shadow and have an entry in
"Password expires" field don't get flagged with "Result: password of
user XYZ has been expired" by AUTH-9288.

Fixes #362

This way, accounts that have ":!!:" in shadow and have an entry in
"Password expires" field don't get flagged with "Result: password of
user XYZ has been expired" by AUTH-9288.

Fixes CISOfy#362
@pyllyukko
Copy link
Contributor Author

pyllyukko commented Mar 22, 2017

I'm still thinking whether this test should disregard locked accounts completely (e.g. :!!$6...).

I can add the commit to this same pull request if you agree, @mboelen?

Of course it can be unlocked by admin to re-enable the expired password, so maybe it's good to be aware of these kind of accounts. Admins can also remove the expired hash from shadow with passwd -d.

@mboelen mboelen merged commit 88f39b9 into CISOfy:master Mar 27, 2017
@mboelen
Copy link
Member

mboelen commented Mar 27, 2017

Thanks, it has been merged. For now, let's leave the test like this. This way these accounts at least show up and the admin can take action.

@mboelen mboelen self-assigned this Mar 27, 2017
@pyllyukko pyllyukko deleted the AUTH-9288-fix branch January 2, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants