Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently updated content missing repo metadata #133

Open
DavidRies opened this issue Oct 29, 2015 · 3 comments
Open

Recently updated content missing repo metadata #133

DavidRies opened this issue Oct 29, 2015 · 3 comments
Assignees

Comments

@DavidRies
Copy link
Contributor

So, I noticed that several recently committed definition updates are not showing up in the list of recently updated definitions on the site. For example, see:
434bbdb

If you look at the updated definitions, you'll see that they do not include metadata indicating that they've been updated. For example:

      <dates>
        <submitted date="2013-11-15T17:30:00.000-05:00">
          <contributor organization="Hewlett-Packard">Chandan M C</contributor>
        </submitted>
        <status_change date="2013-11-21T13:18:01.032-05:00">DRAFT</status_change>
        <status_change date="2013-12-09T04:00:08.324-05:00">INTERIM</status_change>
        <status_change date="2013-12-30T04:00:14.643-05:00">ACCEPTED</status_change>
      </dates>

This metadata is required to power the contributor and recently updated stats, searching and etc.

Including this metadata should be required of contributors and confirming that it's there should be a part of QA (ideally a part of the script).

@wmunyan
Copy link
Contributor

wmunyan commented Feb 9, 2016

Sorry, I havent responded to this one. The <status_change> elements in the example above represent the automatic updates that MITRE had processed. Each update is separated by 2 weeks of time for users and contributors to make modifications. If no comments or updates occurred in the 2 week time period, the status automatically updated...So no real contributors are making any changes. Any modifications made to the content for actual updates do indeed require a <modified> tag and contributor information

@DavidRies
Copy link
Contributor Author

Hi Bill, that makes sense. There's certainly no contributor for an status_change.

I don't remember what prompted this, so maybe it was all a mistake. Out of curiosity, do you check to ensure the appropriate contributor metadata has been added into contributions? Is this a scripted check of some sort or manual?

@wmunyan
Copy link
Contributor

wmunyan commented Feb 9, 2016

Part of the QA script checks to ensure the last <status_change> value is the same as the definition's <status>. Other than that, I currently manually check that the appropriate <modified> or <submitted> contributor information is present and correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants