This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Basic version of JMS endpoint generator (happy path) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
util classes to respective packages
…rvice_framework into crc-1531 # Conflicts: # adapters/adapters-test-utils/pom.xml # adapters/pom.xml # adapters/rest-adapter-generator/pom.xml # adapters/rest-adapter-generator/src/test/java/uk/gov/justice/services/adapters/rest/generator/DefaultGenerator_ResourceCodeStructureTest.java # adapters/rest-adapter-generator/src/test/java/uk/gov/justice/services/adapters/rest/generator/DefaultGenerator_ResourceMethodBodyTest.java
…service_framework into crc-1531 # Conflicts: # adapters/adapters-test-utils/src/main/java/uk/gov/justice/services/adapters/test/utils/builder/ResourceBuilder.java # adapters/jms-adapter-generator/src/main/java/uk/gov/justice/raml/jms/core/JmsEndpointGenerator.java
@@ -29,4 +27,4 @@ | |||
<artifactId>raml-parser</artifactId> | |||
</dependency> | |||
</dependencies> | |||
</project> | |||
</project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file only has formatting changes - can it be excluded from the changeset?
*/ | ||
@Override | ||
public void run(final Raml raml, final GeneratorConfig configuration) { | ||
final File outputDirectory = createOutputDirectories(configuration); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already create and clear the output directory in the plugin - we should standardize on that approach, I think.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.