Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for locale in social login #172

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Fixes for locale in social login #172

merged 3 commits into from
Jan 20, 2020

Conversation

giorgio93p
Copy link
Collaborator

This pull request addresses issue 171.

  1. It makes sure that when a user account is created via social login, the current locale id is written to the new user profile.
  2. It uses an allauth signal to change the locale cookie after login, in order to accommodate social logins.

@giorgio93p
Write correct locale to user profile when signing up via social
a306b1d
@giorgio93p
Merge branch 'master' of https://github.com/CJWorkbench/cjworkbench i…
1a008c9 
…nto rad_socialaccount_i18n
@giorgio93p
Use a signal to set locale cookie after login
22402dd 
Effectively undoes commit 0f8018e

The approach of signals is required because of social login. See issue
#171
for details as to why.
@adamhooper adamhooper merged commit cadc41d into master Jan 20, 2020
@adamhooper adamhooper deleted the rad_socialaccount_i18n branch January 20, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giorgio93p @adamhooper