Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillReceiveProps has been renamed Issue #53

Closed
xogns656 opened this issue Nov 4, 2019 · 3 comments
Closed

componentWillReceiveProps has been renamed Issue #53

xogns656 opened this issue Nov 4, 2019 · 3 comments

Comments

@xogns656
Copy link

xogns656 commented Nov 4, 2019

Hi, Thanks for make this library.
Caching effectively work in my app.
But, repeatedly occur 'componentWillReceiveProps' warning in my app.
Warning is as follows :

react-dom.development.js:12466 Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: CacheComponent

I think present version using componentWillReceiveProps.
I hope to improve this Warning in the next version.
Thank you!

@CJY0208
Copy link
Owner

CJY0208 commented Nov 6, 2019

Got it and will fix it ~

May I know which version of React you are using ?

@CJY0208
Copy link
Owner

CJY0208 commented Nov 7, 2019

Past React version comparison is incorrect, fixed~ enjoy

@xogns656
Copy link
Author

xogns656 commented Nov 8, 2019

Got it and will fix it ~

May I know which version of React you are using ?

Thanks for your reply comment!
I using React 16.10.2 version now.
And warning does not come out.
it means your update good work in my app

carloseduardosx pushed a commit to carloseduardosx/react-router-cache-route that referenced this issue Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants