Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Do not import "sktm" in sktm modules #6

Open
spbnick opened this issue Mar 8, 2018 · 0 comments
Open

Do not import "sktm" in sktm modules #6

spbnick opened this issue Mar 8, 2018 · 0 comments

Comments

@spbnick
Copy link
Contributor

spbnick commented Mar 8, 2018

The sktm/*.py modules should not import "sktm", as that breaks composition. Instead move the required definitions to another module under sktm and import that.

spbnick added a commit to spbnick/sktm that referenced this issue May 24, 2018
Move sktm.tresult to sktm.misc.tresult to fix composition, so that
modules lower in the hierarchy (e.g. sktm.jenkins) do not have to import
the module above (i.e. sktm).

Fixes CKI-project#6
spbnick added a commit to spbnick/sktm that referenced this issue May 28, 2018
Move sktm.tresult to sktm.misc.tresult to fix composition, so that
modules lower in the hierarchy (e.g. sktm.jenkins) do not have to import
the module above (i.e. sktm).

Fixes CKI-project#6
spbnick added a commit to spbnick/sktm that referenced this issue May 28, 2018
Move sktm.tresult to sktm.misc.tresult to fix composition, so that
modules lower in the hierarchy (e.g. sktm.jenkins) do not have to import
the module above (i.e. sktm).

Fixes CKI-project#6
spbnick added a commit to spbnick/sktm that referenced this issue Jun 5, 2018
Move sktm.tresult to sktm.misc.tresult to fix composition, so that
modules lower in the hierarchy (e.g. sktm.jenkins) do not have to import
the module above (i.e. sktm).

Fixes CKI-project#6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant