Prevent double-close of issues (go-gitea#6233)

CL-Jeremy · Mar 5, 2019 · f066bd2 · f066bd2
1 parent 1986269
commit f066bd2
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/models/issue.go b/models/issue.go
@@ -699,8 +699,14 @@ func UpdateIssueCols(issue *Issue, cols ...string) error {
 }
 
 func (issue *Issue) changeStatus(e *xorm.Session, doer *User, isClosed bool) (err error) {
+	// Reload the issue
+	currentIssue, err := getIssueByID(e, issue.ID)
+	if err != nil {
+		return err
+	}
+
 	// Nothing should be performed if current status is same as target status
-	if issue.IsClosed == isClosed {
+	if currentIssue.IsClosed == isClosed {
 		return nil
 	}