Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor before stable version #120

Open
6 of 20 tasks
ktagowski opened this issue Dec 7, 2021 · 2 comments
Open
6 of 20 tasks

Refactor before stable version #120

ktagowski opened this issue Dec 7, 2021 · 2 comments

Comments

@ktagowski
Copy link
Collaborator

ktagowski commented Dec 7, 2021

Issues:

Ideas:
- [ ] Consider refactoring embedding pooling to transformations

  • Consider moving all type aliases to types.py file
  • Consider prefixing boolean variables with should_ or if_ etc.
@laugustyniak
Copy link
Collaborator

@ktagowski do we want to update it or close and review issues separately?

@ktagowski
Copy link
Collaborator Author

ktagowski commented Feb 14, 2023

@laugustyniak Let's move to a new one with a review of the issues, and close that one

  • Some issues are important from a user perspective, therefore, should be prioritized
  • Code improvements can be handled by one refactor.
  • Other issues should be closed or moved to future work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants