-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wandb logging #218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for embeddingsclarinpl canceled.
|
cc791b4
to
8a82fde
Compare
ee52336
to
cf8725e
Compare
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
djaniak
reviewed
Mar 16, 2022
ktagowski
requested changes
Apr 1, 2022
4740159
to
5493ad5
Compare
de075b1
to
109fae6
Compare
ktagowski
requested changes
Apr 5, 2022
djaniak
reviewed
Apr 6, 2022
laugustyniak
previously approved these changes
Apr 6, 2022
ktagowski
previously approved these changes
Apr 6, 2022
ktagowski
approved these changes
Apr 6, 2022
djaniak
approved these changes
Apr 6, 2022
mkossakowski19
pushed a commit
that referenced
this pull request
May 12, 2022
* refactor: move default kwargs * feat(logging): add args for logging * feat(logging): update pyproject and tests * feat(logging): add logging to seq labelling * fix: fixes after rebase * feat(logging): add naming of run in hps * test: repair hps tests * add dataset info to logging * ci(poetry): lock dependencies * feat(logging): add evaluation.json as artifact to wandb * fix: fix artifacts naming * style: fix formatting * feat: make saving params more unified * feat: add dataset version to hparams * feat(logging): organize artifacts * feat(scripts): add hps examples * fix(scripts): fix document classification script * fix: fix lack of test metrics * feat: add logits to evaluation.json * fix: apply softmax to logits * fix: fix test stem in seq labelling * refactor(tests): refactor result path in tests * feat(sequence-labelling): add names and probabilities to returned dict * test: disable mkdirs during tests * fix: fix sequence labelling test * fix: lock dependencies * fix: froze click * refactor: refactor due to comments in PR * feat: add target names to text classification * style: format code * test: fix tests and add missing * refactor: refactor due to pr comments * feat(logging): add LightningLoggingConfig * test: fix hps test * fix: fix literal type import * test: fix hps test * fix: fix list type * ci: update lock * fix: artifacts naming * refactor: edit default exceptions in hps * refactor: move mkdir * refactor: add logger wrappers * refactor: move get_lightning_loggers to loggers config * refactor: refactor due to pr comments Co-authored-by: Albert Sawczyn <albert.sawczyn@pwr.edu.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally close #152, but there is still a problem with the flair hps pipelines e.g. embeddings/pipeline/flair_hps_pipeline.py:139
an example hps logging output:
https://wandb.ai/albert__/test-hps-run-3
for source code: