Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional #95

Merged
merged 21 commits into from
Apr 4, 2018
Merged

Optional #95

merged 21 commits into from
Apr 4, 2018

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 3, 2018

Initial tests for support for Options, and cleanup. Closes #9. Supports std::optional, std::experimental::optional, and boost::optional if your compiler supports __has_include (You can manually add support if __has_include is missing).

Other changes:

  • C++ version check now in Macros.hpp, is similar to Pybind11
  • Fix for non-cleared stream in some cases
  • CLI11_* is used for all macros and CMake variables
  • Deprecated macros now work properly
  • C++17 testing added
  • Rewritten single file generator, much more powerful, with "verbatim" support
  • Added informational printout to CTest
  • Added support for GTest on MSVC 2017 (but not in C++17 mode, will need GTest 1.8.1 when released)

@henryiii henryiii force-pushed the optional branch 4 times, most recently from d4ea652 to f114426 Compare April 3, 2018 09:29
@codecov
Copy link

codecov bot commented Apr 3, 2018

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1395   1399    +4     
=====================================
+ Hits         1395   1399    +4
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <ø> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea833b...9dee439. Read the comment docs.

@henryiii henryiii force-pushed the optional branch 2 times, most recently from 9b71713 to bc895e3 Compare April 4, 2018 09:40
@henryiii henryiii merged commit de06d50 into master Apr 4, 2018
@henryiii henryiii deleted the optional branch April 4, 2018 19:17
@henryiii henryiii added this to the v1.5 milestone Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant