Adjusting strand.rb find_by_member methods to correct cc_question N+1…

… issue
CLOSER-Cohorts · Feb 7, 2019 · 584bdf5 · 584bdf5
1 parent 3c0b0c8
commit 584bdf5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/models/response_domain_code.rb b/app/models/response_domain_code.rb
@@ -25,7 +25,7 @@ class ResponseDomainCode < ApplicationRecord
   #
   # @return [Array] List of codes as hashes
   def codes
-    self.code_list.codes.map do |x|
+    self.code_list.codes.includes(:code_list).map do |x|
       {
           label: x.category.label,
           value: x.value,

diff --git a/app/models/strand.rb b/app/models/strand.rb
@@ -78,12 +78,12 @@ def self.find(id)
   # @return [Strand]
   def self.find_by_member(member)
     begin
-      id = redis.hget LOOKUP, member.typed_id
+      @id ||= redis.hget LOOKUP, member.typed_id
     rescue Redis::CannotConnectError
       Rails.logger.warn 'Cannot connect to Redis'
     end
-    return nil if id.nil?
-    return Strand.find(id.to_i)
+    return nil if @id.nil?
+    return Strand.find(@id.to_i)
   end
 
   # Rebuilds all Strands

diff --git a/...est-d5689baf41edf3670a3a2dd657ac04b7.json → ...est-e8b5284dc0665fd264a78b88955a08eb.json b/...est-d5689baf41edf3670a3a2dd657ac04b7.json → ...est-e8b5284dc0665fd264a78b88955a08eb.json