Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated detector noise #8

Merged
merged 18 commits into from
Jul 13, 2020
Merged

updated detector noise #8

merged 18 commits into from
Jul 13, 2020

Conversation

smsimon
Copy link
Contributor

@smsimon smsimon commented Apr 29, 2020

updated LAT noise to match calculations using SO v3 Goal sensitivity calculator

@smsimon smsimon requested a review from keskitalo April 29, 2020 17:38
@@ -450,7 +450,7 @@ def get_example():
bnd["low"] = 255.5
bnd["high"] = 300.5
bnd["bandpass"] = ""
bnd["NET"] = 1281.0
bnd["NET"] = 2077.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a pretty big difference!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old one apparently was very similar to the SAT, but scaled for the different bands, but the LAT has much smaller pixels for the high frequencies (so it makes sense that the noise is much higher). There are many more pixels though so we get more averaging.

bnd = OrderedDict()
bnd["center"] = 27.0
bnd["low"] = 24.0
bnd["high"] = 30.0
bnd["bandpass"] = ""
bnd["NET"] = 177.0
bnd["NET"] = 387.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that. We'll certainly want to redo the noise simulation for the baseline simulation tool

@@ -297,13 +297,13 @@ def get_example():
bnd["A"] = 0.09
bnd["C"] = 0.87
bands["ULFL1"] = bnd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your editor leaves a lot of these orphan indentations. Is there an easy way for you to clean them up? You could try running black on the source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I will look into that/use a different editor in the future.

@zonca zonca mentioned this pull request Apr 29, 2020
Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but would be even better with the source formatting so the empty lines do not show up in diffs.

@zonca zonca requested review from zonca and removed request for zonca April 29, 2020 17:47
@smsimon smsimon changed the title updated LAT noise updated detector noise May 20, 2020
@zonca
Copy link
Member

zonca commented Jun 3, 2020

When this is merge can you please tag a release on GitHub?

@smsimon
Copy link
Contributor Author

smsimon commented Jun 3, 2020

Yes, we should add a tag when the full branch is merged. I have also been keeping the change log up to date so will put the release name in there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants