-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated detector noise #8
Conversation
s4sim/hardware/config.py
Outdated
@@ -450,7 +450,7 @@ def get_example(): | |||
bnd["low"] = 255.5 | |||
bnd["high"] = 300.5 | |||
bnd["bandpass"] = "" | |||
bnd["NET"] = 1281.0 | |||
bnd["NET"] = 2077.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a pretty big difference!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old one apparently was very similar to the SAT, but scaled for the different bands, but the LAT has much smaller pixels for the high frequencies (so it makes sense that the noise is much higher). There are many more pixels though so we get more averaging.
s4sim/hardware/config_1shooter.py
Outdated
bnd = OrderedDict() | ||
bnd["center"] = 27.0 | ||
bnd["low"] = 24.0 | ||
bnd["high"] = 30.0 | ||
bnd["bandpass"] = "" | ||
bnd["NET"] = 177.0 | ||
bnd["NET"] = 387.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that. We'll certainly want to redo the noise simulation for the baseline simulation tool
s4sim/hardware/config_1shooter.py
Outdated
@@ -297,13 +297,13 @@ def get_example(): | |||
bnd["A"] = 0.09 | |||
bnd["C"] = 0.87 | |||
bands["ULFL1"] = bnd | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your editor leaves a lot of these orphan indentations. Is there an easy way for you to clean them up? You could try running black
on the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I will look into that/use a different editor in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but would be even better with the source formatting so the empty lines do not show up in diffs.
145 GHz band and 95 GHz noise levels were switched
When this is merge can you please tag a release on GitHub? |
Yes, we should add a tag when the full branch is merged. I have also been keeping the change log up to date so will put the release name in there as well. |
updated LAT noise to match calculations using SO v3 Goal sensitivity calculator