Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable Group: Image gallery empties on changing order #187

Closed
Gaffen opened this issue Feb 13, 2015 · 3 comments
Closed

Repeatable Group: Image gallery empties on changing order #187

Gaffen opened this issue Feb 13, 2015 · 3 comments

Comments

@Gaffen
Copy link

Gaffen commented Feb 13, 2015

CMB 2.0.1, Wordpress 4.1

If a repeatable group has an image gallery in it, changing the order removes the gallery from the one that end up on top, replacing it from the gallery below.

Test case:

  1. Create two repeatable field items, assign them names and image galleries:
    screen shot 2015-02-13 at 14 42 34
  2. Update the post
  3. Change the order of the items.
  4. Update the post
  5. One of the galleries disappears and the other is replaced
    screen shot 2015-02-13 at 14 42 46

This is inconvenient as it makes it difficult to hand projects over to clients knowing they may accidentally start undoing image galleries.

@Gaffen Gaffen changed the title Repeatable Group: Image gallery empties on changing the ]order Repeatable Group: Image gallery empties on changing order Feb 13, 2015
@bonny
Copy link

bonny commented Feb 23, 2015

This happens for us too. Re-order = images get lost.

@bonny
Copy link

bonny commented Feb 23, 2015

Ok, I just made a fix that you can see above. Was going to create a pull request when I saw that this probably was fixed in #153 already (but not merged yet - let's hope it will be soon because we can't release our client website until this is fixed)

@jtsternberg
Copy link
Member

This is fixed in trunk and will be in the next release, thanks to @jamiechong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants