Fix sorting of Groups with file lists, radio buttons in Groups #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues with a repeatable and sortable group that contained a radio_inline field and a file_list field.
The radio button issues were documented in #150 and #152.
There were a few bugs when trying to sort a group that had a file_list. #187
$goto.find( cmb.repeatEls ).each( function( index )
if the number of images in the two file_lists being swapped differed. This was because theindex
id was based off the number ofinput
elements, which are hidden for file_lists. I fixed this on line 26repeatEls : 'input:not([type="button"],[id^=filelist]),select,textarea,.cmb2-media-status',
629 to 645