Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of Groups with file lists, radio buttons in Groups #265

Closed
wants to merge 5 commits into from

Conversation

jamiechong
Copy link
Contributor

I had some issues with a repeatable and sortable group that contained a radio_inline field and a file_list field.

The radio button issues were documented in #150 and #152.

There were a few bugs when trying to sort a group that had a file_list. #187

  1. There was a javascript error in the loop of $goto.find( cmb.repeatEls ).each( function( index ) if the number of images in the two file_lists being swapped differed. This was because the index id was based off the number of input elements, which are hidden for file_lists. I fixed this on line 26 repeatEls : 'input:not([type="button"],[id^=filelist]),select,textarea,.cmb2-media-status',
  2. The attribute names of the file_list hidden input fields that set the image id didn't correspond with the correct row number. This is fixed in line 629 to 645

@jamiechong
Copy link
Contributor Author

I'm not sure what the "Failed" check is, but this pull request is legit. It's the same PR as #153 but you wanted me to apply changes to trunk. Hopefully you can get this into a near-future release! At least look at the changes - maybe you want to implement the fixes in another way. Thanks!

@jamiechong
Copy link
Contributor Author

trashing this PR.

@jamiechong jamiechong closed this Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant