Remove superfluous method definitions #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes unneeded method definitions from the class DocBlock. These methods are defined within the class, and so the `@method` tags aren't necessary (and in fact result in inspection errors in IDEs; in PhpStorm they trigger a "Method with same name already defined in this class" error). Reference: http://docs.phpdoc.org/references/phpdoc/tags/method.html
|
👍 |
jtsternberg
added a commit
that referenced
this pull request
Dec 21, 2018
lipemat
added a commit
to lipemat/CMB2
that referenced
this pull request
Jan 4, 2019
* upstream/develop: make use of phpunit 6.5 for PHP 5.6. fix failing test for group removal confirmation message. Add props for CMB2#1208 Move the remove_confirm option to the example functions and leave default empty (to not break back-compat) Oops, fix typeof yoda check Fix removal confirmation in tests Simplify removal confirmation check Update typeof checks to use yoda make remove confirmation a bit more succinct Cannot use empty on an operation on older versions of php see CMB2#529 - improvements as per PR review: see CMB2#529 - fix tests with a default confirm value in DOM equal to no. fix CMB2#529 - Add confirm dialog to group Remove button. Add props for CMB2#1206 Add php tests npm script Add grunt watch npm script Add props for CMB2#1204 Ignore composer vendor dir fix CMB2#1205 - Package.json: fix the need of global (old) grunt. fix 1023 - Update PHPUnit version in composer.json. Add props for CMB2#1200 Remove superfluous method definitions Add develop class suffix to init.php class Bump version for hotfix release Fix issue when wp.data does not have core/editor. Check it first. Fixes CMB2#1197 Update version to 2.5.0 Update changelog Make install-wp-tests.sh executable Update tests to pass Add cmb_init_pickers and cmb_init_code_editors events for allowing just-in-time configuration for pickers/editors Make CMB2.getFields/CMB2.getFields more robust, allowing a filter callback, and specifying by field id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes unneeded method definitions from the class DocBlock. These methods are defined within the class, and so the
@methodtags aren't necessary (and in fact result in inspection errors in IDEs; in PhpStorm they trigger a "Method with same name already defined in this class" error).Reference: http://docs.phpdoc.org/references/phpdoc/tags/method.html