Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPUnit version in composer.json #1204

Merged
merged 2 commits into from Dec 30, 2018

Conversation

slaFFik
Copy link
Member

@slaFFik slaFFik commented Dec 29, 2018

Fixes #1203.

Changes proposed in this pull request

  • add composer.lock into the repo
  • up the phpunit version to 6.5.* so tests will start working when running a locally project-level installed phpunit

@slaFFik slaFFik self-assigned this Dec 29, 2018
Copy link
Member

@jtsternberg jtsternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jtsternberg jtsternberg merged commit 7b6a51c into develop Dec 30, 2018
jtsternberg added a commit that referenced this pull request Dec 30, 2018
lipemat added a commit to lipemat/CMB2 that referenced this pull request Jan 4, 2019
* upstream/develop:
  make use of phpunit 6.5 for PHP 5.6.
  fix failing test for group removal confirmation message.
  Add props for CMB2#1208
  Move the remove_confirm option to the example functions and leave default empty (to not break back-compat)
  Oops, fix typeof yoda check
  Fix removal confirmation in tests
  Simplify removal confirmation check
  Update typeof checks to use yoda
  make remove confirmation a bit more succinct
  Cannot use empty on an operation on older versions of php
  see CMB2#529 - improvements as per PR review:
  see CMB2#529 - fix tests with a default confirm value in DOM equal to no.
  fix CMB2#529 - Add confirm dialog to group Remove button.
  Add props for CMB2#1206
  Add php tests npm script
  Add grunt watch npm script
  Add props for CMB2#1204
  Ignore composer vendor dir
  fix CMB2#1205 - Package.json: fix the need of global (old) grunt.
  fix 1023 - Update PHPUnit version in composer.json.
  Add props for CMB2#1200
  Remove superfluous method definitions
  Add develop class suffix to init.php class
  Bump version for hotfix release
  Fix issue when wp.data does not have core/editor. Check it first. Fixes CMB2#1197
  Update version to 2.5.0
  Update changelog
  Make install-wp-tests.sh executable
  Update tests to pass
  Add cmb_init_pickers and cmb_init_code_editors events for allowing just-in-time configuration for pickers/editors
  Make CMB2.getFields/CMB2.getFields more robust, allowing a filter callback, and specifying by field id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants