Fix rest_value_cb registering of filter
#1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, nice catch. This was definitely a typo. |
jtsternberg
added a commit
that referenced
this pull request
Jan 4, 2019
|
Coincidentally, would appreciate if you are willing to add docs for |
|
Documentation completed for both Field Parameters and Rest Api |
|
Awesome, thank you! |
lipemat
added a commit
to lipemat/CMB2
that referenced
this pull request
Apr 9, 2019
* upstream/develop: Corrected link to facetwp-cmb2 in README.md (CMB2#1248) Implement attribute escaping per VIP standards/@GaryJones Update readme with more available 3rd-party resources Ensure date picker fields can have a default value. Fixes CMB2#1245 Ignore some more directories in the distribution package. Do exclude composer.lock file from archive Don't exclude composer.json from the distribution. Add example for using the query_args field arg to override the get_terms args assignment alignment and space replacement with tabs phpdoc and comment touchups Try to make travis happy Update changelog Rename row variables in cmb.addAjaxRow as technically the emtpyRow is the one being passed around. Also pass the new row to the cmb2_add_row trigger use phpunit 5.7 in PHP 5.6 Add develop suffix to the loader Add apigen to version control Prep 2.6.0 for release Oops, fix the fix (from bcec44e) Add props for CMB2#588. Closes CMB2#588 Add props for CMB2#463. Closes CMB2#463 Add props for CMB2#953. Closes CMB2#953 Ditch the field args, and only pass in the field object to the new field before/after hooks, and clean up docs Remove unused variables/method attributes Ensure value passed to CMB2_Utils::filter_empty is always an array. Fixes CMB2#1026 Add section for Creating/Running Tests Add magic getter for CMB2_Option class. Fixes CMB2#1052 Add props for CMB2#1108. Closes CMB2#1108 Update test to reflect postbox groups getting ids Update cmb-group-id functionality a bit Add props for CMB2#1216 update github issue/PR templates Do not trigger tinyMCE editor save for the activeEditor. Prevents cursor jump in Gutenberg. Fixes CMB2#1202 see CMB2#1214 - fix tests. see CMB2#1214 - better placement of the lib dep registration. fix CMB2#1214 - Making a field repeatable generates JS error because of missing sortable lib. Add props for CMB2#1212 Added 'id' attribute on group field ref class 'postbox cmb-row cmb-repeatable-grouping' Before/After row hooks Document the new field_argument filters, remove superfluous parameters and and change the last parameter to `$this`. Introduce three new filters to filter field arguments. WP_DEVELOP_DIR != $test_root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: The usage of the rest_value_cb field property
The CMB2_Field has support for a (currently undocumented) property named
rest_value_cbwithin theget_rest_valuemethod.Currently, there is a
apply_filterscall which does nothing because it does have set a value when invoked. The second argument passed toapply_filtersis 99 which suggests this is actually a priority vs a magic number.Changing
apply_filterstoadd_filterallows this property to work while leaving the arguments intact.Changes proposed in this pull request
Change
apply_filterstoadd_filter.