Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before/After row hooks #953

Closed
wants to merge 2 commits into from

Conversation

@rubengc
Copy link
Contributor

commented Apr 13, 2017

Same PR as #946

Fixes #876

Added
cmb2_before_field_row
cmb2_before_{$field_type}field_row
cmb2_after_{$field_type}_field_row
cmb2_after_field_row

@rubengc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2017

@tw2113

This comment has been minimized.

Copy link
Contributor

commented Sep 21, 2018

@rubengc I realize it's been awhile. Our apologies there.

What is the difference between these and the options available with https://github.com/CMB2/CMB2/wiki/Field-Parameters#before-after-before_row-after_row-before_field-after_field ? All of those receive the field args and field object which very closely matches what you're doing with your PR.

@jtsternberg jtsternberg changed the base branch from trunk to develop Jan 18, 2019

lipemat added a commit to lipemat/CMB2 that referenced this pull request Apr 9, 2019
Merge remote-tracking branch 'upstream/develop' into develop
* upstream/develop:
  Corrected link to facetwp-cmb2 in README.md (CMB2#1248)
  Implement attribute escaping per VIP standards/@GaryJones
  Update readme with more available 3rd-party resources
  Ensure date picker fields can have a default value. Fixes CMB2#1245
  Ignore some more directories in the distribution package.
  Do exclude composer.lock file from archive
  Don't exclude composer.json from the distribution.
  Add example for using the query_args field arg to override the get_terms args
  assignment alignment and space replacement with tabs
  phpdoc and comment touchups
  Try to make travis happy
  Update changelog
  Rename row variables in cmb.addAjaxRow as technically the emtpyRow is the one being passed around. Also pass the new row to the cmb2_add_row trigger
  use phpunit 5.7 in PHP 5.6
  Add develop suffix to the loader
  Add apigen to version control
  Prep 2.6.0 for release
  Oops, fix the fix (from bcec44e)
  Add props for CMB2#588. Closes CMB2#588
  Add props for CMB2#463. Closes CMB2#463
  Add props for CMB2#953. Closes CMB2#953
  Ditch the field args, and only pass in the field object to the new field before/after hooks, and clean up docs
  Remove unused variables/method attributes
  Ensure value passed to CMB2_Utils::filter_empty is always an array. Fixes CMB2#1026
  Add section for Creating/Running Tests
  Add magic getter for CMB2_Option class. Fixes CMB2#1052
  Add props for CMB2#1108. Closes CMB2#1108
  Update test to reflect postbox groups getting ids
  Update cmb-group-id functionality a bit
  Add props for CMB2#1216
  update github issue/PR templates
  Do not trigger tinyMCE editor save for the activeEditor. Prevents cursor jump in Gutenberg. Fixes CMB2#1202
  see CMB2#1214 - fix tests.
  see CMB2#1214 - better placement of the lib dep registration.
  fix CMB2#1214 - Making a field repeatable generates JS error because of missing sortable lib.
  Add props for CMB2#1212
  Added 'id' attribute on group field ref class 'postbox cmb-row cmb-repeatable-grouping'
  Before/After row hooks
  Document the new field_argument filters, remove superfluous parameters and and change the last parameter to `$this`.
  Introduce three new filters to filter field arguments.
  WP_DEVELOP_DIR != $test_root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.