Repeatable group number incorrect #310
Comments
|
|
Glad to know that I'm not the only one. Looks like it may be a bug. |
|
This was definitely a bug and is now fixed in trunk. Please test. |
|
Thank you! It's working well for me now :) |
|
can someone please tell me if this fix has been included in the github repo, I'm not sure what 'trunk' is refering to. thanks |
|
@jajouka79 it is in the trunk branch and will be in master when we release the next version. You can download trunk or checkout the trunk branch from the repo. |
|
ok, thanks justin On 11/05/15 18:28, Justin Sternberg wrote:
|
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this issue
May 29, 2015
* Ability to use non-repeatable group fields by setting the `'repeatable'` field param to `false` when registering a group field type. Props [marcusbattle](https://github.com/marcusbattle), ([#159](CMB2/CMB2#159)). * Add and enqeueue a front-end specific CSS file which adds additional styles which are typically covered by wp-admin css. ([#311](CMB2/CMB2#311)) * Better handling of the CMB2 javascript (and CSS) required dependencies array. Dependencies are now only added conditionally based on the field types that are actually visible. ([#136](CMB2/CMB2#136)) * **THIS IS A BREAKING CHANGE:** The `group` field type's `'show_on_cb'` property now receives the `CMB2_Field` object instance as an argument instead of the `CMB2` instance. If you're using the `'show_on_cb'` property for a `group` field, please adjust accordingly. _note: you can still retrieve the `CMB2` instance via the `cmb2_get_metabox` helper function._ * New dynamic hook, `"cmb2_save_{$object_type}_fields_{$this->cmb_id}"`, to complement the existing `"cmb2_save_{$object_type}_fields"` hook. * New CMB2 property, `enqueue_js`, to disable the enqueueing of the CMB2 Javascript. * German translation provided by Friedhelm Jost. ### Bug Fixes * Fix incorrect repeatable group title number. ([#310](CMB2/CMB2#310)) * Fix obscure bug which prevented group field arguments from being passed to the sub-fields (like `show_names` and `context`). * Fixed occasional issue when adding a group row, the previous row's content would be cloned. ([#257](CMB2/CMB2#257)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1169742 b8457f37-d9ea-0310-8a92-e5e31aec5664
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this issue
May 29, 2015
* Ability to use non-repeatable group fields by setting the `'repeatable'` field param to `false` when registering a group field type. Props [marcusbattle](https://github.com/marcusbattle), ([#159](CMB2/CMB2#159)). * Add and enqeueue a front-end specific CSS file which adds additional styles which are typically covered by wp-admin css. ([#311](CMB2/CMB2#311)) * Better handling of the CMB2 javascript (and CSS) required dependencies array. Dependencies are now only added conditionally based on the field types that are actually visible. ([#136](CMB2/CMB2#136)) * **THIS IS A BREAKING CHANGE:** The `group` field type's `'show_on_cb'` property now receives the `CMB2_Field` object instance as an argument instead of the `CMB2` instance. If you're using the `'show_on_cb'` property for a `group` field, please adjust accordingly. _note: you can still retrieve the `CMB2` instance via the `cmb2_get_metabox` helper function._ * New dynamic hook, `"cmb2_save_{$object_type}_fields_{$this->cmb_id}"`, to complement the existing `"cmb2_save_{$object_type}_fields"` hook. * New CMB2 property, `enqueue_js`, to disable the enqueueing of the CMB2 Javascript. * German translation provided by Friedhelm Jost. ### Bug Fixes * Fix incorrect repeatable group title number. ([#310](CMB2/CMB2#310)) * Fix obscure bug which prevented group field arguments from being passed to the sub-fields (like `show_names` and `context`). * Fixed occasional issue when adding a group row, the previous row's content would be cloned. ([#257](CMB2/CMB2#257)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1169744 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have made a repeatable group that has two fields; a text field and a file list field. When adding more groups, the group number title is correct (i.e for every added group, it increases by one). However, upon saving it shows each group as just number 1.
Is this a known bug? I am using the latest version of CMB2, using the wordpress.org plugin.
The text was updated successfully, but these errors were encountered: