Support for custom date and time formats for the text_datetime_timestamp and text_date_timestamp fields #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text_date, text_date_timestamp and text_datetime_timestamp fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "date_format" and "time_format" arguments didn't work with fields of type "text_datetime_timestamp" or "text_date_timestamp".
I reported and fixed this already in #498, but some other fix was applied that only worked for other date/time fields, but not those two. This is basically just a rebase of #498 with the missing fix for "text_datetime_timestamp" and "text_date_timestamp".