EASI-4374: improve cedarproxy deployment stability (#2597)

* EASI-4374: always build and deploy cedarproxy * EASI-4374: ecs wait to ensure deployment is successful
CMS-Enterprise · May 22, 2024 · d511928 · d511928
1 parent 1bf8386
commit d511928
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/build_cedarproxy_image.yml b/.github/workflows/build_cedarproxy_image.yml
@@ -6,7 +6,7 @@ on:
       force_cedarproxy:
         required: true
         type: boolean
-        default: false
+        default: true # Per EASI-4374, we want to force cedarproxy deployments in the event pipeline deployment is skipped/cancelled
 
 env:
   EASI_APP_NODE_VERSION: "16.14.0"

diff --git a/.github/workflows/deploy_cedarproxy.yml b/.github/workflows/deploy_cedarproxy.yml
@@ -1,4 +1,4 @@
-name: Deploy to Environment
+name: Deploy Cedarproxy to Environment
 
 on:
   workflow_call:
@@ -9,7 +9,7 @@ on:
       force_cedarproxy:
         required: true
         type: boolean
-        default: false
+        default: true # Per EASI-4374, we want to force cedarproxy deployments in the event pipeline deployment is skipped/cancelled
 
 env:
   GIT_HASH: ${{ github.sha }}

diff --git a/.github/workflows/deploy_pipeline.yml b/.github/workflows/deploy_pipeline.yml
@@ -34,7 +34,7 @@ jobs:
     uses: ./.github/workflows/build_cedarproxy_image.yml
     secrets: inherit
     with:
-      force_cedarproxy: false
+      force_cedarproxy: true
 
   Run_Tests:
     uses: ./.github/workflows/run_tests.yml
@@ -47,15 +47,15 @@ jobs:
     with:
       env: dev
       lambda_version: 10
-      force_cedarproxy: false
+      force_cedarproxy: true # Per EASI-4374, we want to force cedarproxy deployments in the event pipeline deployment is skipped/cancelled
     secrets: inherit
 
   deploy_impl:
     needs: [deploy_dev, Build_Frontend_Assets]
     uses: ./.github/workflows/deploy_to_environment.yml
     with:
       env: impl
-      force_cedarproxy: false
+      force_cedarproxy: true # Per EASI-4374, we want to force cedarproxy deployments in the event pipeline deployment is skipped/cancelled
       lambda_version: 9
     secrets: inherit
 
@@ -64,6 +64,6 @@ jobs:
     uses: ./.github/workflows/deploy_to_environment.yml
     with:
       env: prod
-      force_cedarproxy: false
+      force_cedarproxy: true # Per EASI-4374, we want to force cedarproxy deployments in the event pipeline deployment is skipped/cancelled
       lambda_version: 8
     secrets: inherit
diff --git a/scripts/deploy_ecs_service.sh b/scripts/deploy_ecs_service.sh
@@ -14,3 +14,5 @@ aws ecs update-service --cluster "${ECS_CLUSTER}" \
                        --service "${SERVICE_NAME}" \
                        --task-definition "${TASK_FAMILY}:${TASK_REVISION}" \
                        --no-cli-pager
+
+aws ecs wait services-stable --cluster "${ECS_CLUSTER}" --service "${SERVICE_NAME}"