Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASI-4374: improve cedarproxy deployment stability #2597

Merged
merged 2 commits into from
May 22, 2024

Conversation

Jdwoodson
Copy link
Contributor

EASI-4374

Changes and Description

  • Always build and deploy cedarproxy
  • call aws ecs wait after updating deployment to ensure service is healthy

How to test this change

Pipeline changes, no local testing required.

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@Jdwoodson Jdwoodson added the github_actions Pull requests that update Github_actions code label May 22, 2024
@Jdwoodson Jdwoodson self-assigned this May 22, 2024
@Jdwoodson Jdwoodson requested a review from a team as a code owner May 22, 2024 16:20
@Jdwoodson Jdwoodson requested review from mynar7 and removed request for a team May 22, 2024 16:20
@Jdwoodson
Copy link
Contributor Author

Copy link
Contributor

@samoddball samoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: if it works!

@Jdwoodson Jdwoodson merged commit d511928 into main May 22, 2024
16 checks passed
@Jdwoodson Jdwoodson deleted the EASI-4374/improve-cedarproxy-deployment-stability branch May 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants