Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded total number of layers #70

Closed
apsallid opened this issue Apr 4, 2019 · 2 comments
Closed

Hardcoded total number of layers #70

apsallid opened this issue Apr 4, 2019 · 2 comments
Assignees
@clelange

Comments

@apsallid
Copy link

apsallid commented Apr 4, 2019

52 is given hardcoded when using retrieveLayerPositions. There are no longer 52 layers in V10 (D41) but 50 and it would be good to read those values from CMSSW. This issue here is related [1].

[1] cms-sw/cmssw#26225
@clelange
Copy link
Contributor

With cms-sw/cmssw#27128 merged, we only need a new CMSSW release and can then remove hardcoded values.

@clelange
Copy link
Contributor

clelange commented Jul 8, 2019

The updated RecHitTools are now in a release: CMSSW_11_0_0_pre3.

@clelange clelange self-assigned this Jul 8, 2019
@clelange clelange mentioned this issue Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clelange clelange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apsallid @clelange