-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up HGCal subdetector terminology and usage #26225
Comments
assign upgrade |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Issue was created by @kpedro88 Kevin Pedro. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
@kpedro88 |
The V10 geometry has a different number of layers than V9. This clearly can't be handled well with a hardcoded constant. The approach really needs to be reassessed. I highly doubt V10 will be the last major change before we actually build the HGCal. |
HGCal... |
From @cseez #26099 (comment):
Right now,
RecHitTools
haslastLayerEE()
andlastLayerFH()
functions. It should be checked that the usage of these functions is correct. In addition, functions likelastLayerFine()
andlastLayerCoarse()
can be added to present the indicated information in a clear way.attn: @bsunanda @rovere
The text was updated successfully, but these errors were encountered: