[WNMGDS-2722] New browser testing wrapper script #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really I need to use spawn, but that means all my args need to be in array form
Updating any of these is as simple as passing `-u` now. We can even use one of these aliases and pass `--no-docker` to it, like `yarn test:browser:examples --no-docker`, and it will work
…nt on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testing
pwolfert
added
Type: Internal
zarahzachz
reviewed
Apr 1, 2024
zarahzachz
approved these changes
Apr 1, 2024
pwolfert
changed the title
pwolfert
added a commit
that referenced
this pull request
Apr 4, 2024
* Start to a wrapper script for browser tests * This is readable, but using exec crashes because the buffer fills up Really I need to use spawn, but that means all my args need to be in array form * This works! * Build prereqs first unless `--no-build` is passed * Update all the browser test commands Updating any of these is as simple as passing `-u` now. We can even use one of these aliases and pass `--no-docker` to it, like `yarn test:browser:examples --no-docker`, and it will work * Update the unit test commands to match * Rewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testingRewrite the README content on browser testing * Add an example debug command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WNMGDS-2722
Implements the idea in #2810 to make it easier to run browser tests in or out of docker and pass relevant arguments to Playwright regardless of which environment it's running in. See the updated README for more information.
How to test
Run
yarn test:browserand any of its subcommands. Try passing the new flags in or any Playwright flag. Here are some example commands to try:yarn test:browser --listyarn test:browser:interaction --no-docker --no-build --headed --debug --ignore-snapshots --grep "Dropdown"yarn test:browser:examplesyarn test:browser:storybook-docs --no-build --grep "Text" --listChecklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.