Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Revises release v11 blog post #3213

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kim-cmsds
Copy link
Collaborator

Summary

  • Removes reference to removing the privacy settings dialog

How to test

  1. Instructions on how to test the changes in this PR.

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@kim-cmsds kim-cmsds added Type: Fixed Indicates an unexpected problem or unintended behavior Impacts: Documentation Indicates that this item relates to documentation labels Sep 3, 2024
@kim-cmsds kim-cmsds added this to the 11.0.0-beta.1 milestone Sep 3, 2024
Copy link
Collaborator

@jack-ryan-nava-pbc jack-ryan-nava-pbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kim-cmsds kim-cmsds merged commit 5848a30 into main Sep 3, 2024
1 check passed
@kim-cmsds kim-cmsds deleted the kniedermaier/no-ticket/update-v11-blogpost branch September 3, 2024 20:04
@kim-cmsds kim-cmsds restored the kniedermaier/no-ticket/update-v11-blogpost branch September 4, 2024 16:07
jack-ryan-nava-pbc pushed a commit that referenced this pull request Sep 5, 2024
update v11 blog post to remove reference to removing the privacy settings dialog
jack-ryan-nava-pbc added a commit that referenced this pull request Sep 10, 2024
* Initial file creation and addition of copy

* Punctuation updates.

* Updating snapshots

* Revert "Updating snapshots"

This reverts commit fd0f3bc.

* [WNMGDS-2861] Adds PrintIcon component (#3196)

* Add PrintIcon component.

* Removed fillColor attribute from PrintIcon componet and removed lint from incons.stories.tsx

* [WNMGDS-2878] Render Doc Site stories for Modal Dialog and Drawer (#3203)

Copy changes and add ability to handle control arguments

* Added print icon

* [WNMGDS-2861] Adds Email, Link, RSS & What's New Icon components (#3202)

* Adds Email and RSS icons.

* Adds Link and What's New Icons

* Exchange (') for curly (’)

* Adding all icons and text

* Making left icon boolean text explicitly relate to Figma

* Ghost buttons and two columns

* Addressed much feedback

* Revise examples box

* [NO-TICKET] Automatically format json files (#3206)

* Run prettier on json files

* Update lint-staged config to format json files

* [WNMGDS-2875] Fix Release script take 2 (#3205)

* Export vars and function needed in release script

* Reorder imports and add new reviewers

* Add new utility functions used by bumpVersions

* Handle staging files properly

* Export correct function from versions

* export readJson so maybe we capture new line with read file'
'

* big refactor add comments break up inline for loop and associated functions

* Wrap removal of top level package json in try catch and uncomment woopsie

* Add maybe more helpful comment

* Further refactoring

* Looks like a big refactor but basically moved all code to a new file

* Adding functionality so we don't lose newline at end of json files

* [NO-TICKET] Automatically format json files (#3206)

* Run prettier on json files

* Update lint-staged config to format json files

* Undo new line addition when writing json

* Fix typo

* Move version number into our main function to make usage clearer

---------

Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>

* [RELEASE] 8/12 Version bump main (#3200)

* Publish

 - @cmsgov/design-system@11.0.0-beta.0
 - @cmsgov/ds-cms-gov@11.0.0-beta.0
 - @cmsgov/ds-healthcare-gov@15.0.0-beta.0
 - @cmsgov/ds-medicare-gov@13.0.0-beta.0

* [NO-TICKET] Manually updates "@cmsgov/design-system" version in package dependencies (#3201)

manually updates dependency of "@cmsgov/design-system" version

* Reverts design-system-tokens version back to 0.0.1

---------

Co-authored-by: Kim Niedermaier <kimniedermaier+cmsds@navapbc.com>
Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>

* [WNMGDS-2884] Add `cmsds-migrate` script for v11 CSS changes (#3208)

* Basic migration script for v11 variable/class changes

* These two variables weren't removed!

We need to update our release notes, because that was a mistake

* Fix syntax error (stray single quote)

* Fix regex group not getting printed in the replacement text

* Mention the migration script in the blog post and explain how to use it

* [WNMGDS-2890] Fix `onAnalyticsEvent` attribute rendering to DOM through `HelpDrawer` (#3210)

Fix `onAnalyticsEvent` prop bleeding into `dialog` DOM elements through `HelpDrawer`

Without this fix, the unit test I added will print errors to the console like this:

```
console.error
    Warning: Unknown event handler property `onAnalyticsEvent`. It will be ignored.
        at dialog
        at NativeDialog (/Users/patrickwolfert/Projects/design-system/packages/design-system/src/components/NativeDialog/NativeDialog.tsx:38:3)
        at Drawer (/Users/patrickwolfert/Projects/design-system/packages/design-system/src/components/Drawer/Drawer.tsx:73:5)
        at HelpDrawer (/Users/patrickwolfert/Projects/design-system/packages/design-system/src/components/HelpDrawer/HelpDrawer.tsx:13:11)
```

* [NO-TICKET] Define a better return type for `defaultMenuLinks` (#3211)

Be more informative about what `defaultMenuLinks` returns in the types

Previously the return type was `{}`, which is useless to teams trying to use that functions themselves

* [NO-TICKET] Revises release v11 blog post (#3213)

update v11 blog post to remove reference to removing the privacy settings dialog

* [NO-TICKET] Exclude core design system from dependency update (#3217)

* filter out the core design system

* Add comment and make conditional more readable

* make conditional more readable

* [WNMGDS-2713] Add default value overrides to Storybook (#3216)

* Initial set of default values added to props tables

* Updated storybook snaps

* [WNMGDS-2838] Update all themes to make inline tool tips black (#3199)

* Update all themes to make inline tool tips black

* Udpate playwright vrt snapshots

* Updating css snapshots

* Updated css themes and custom tooltip scss styling to maybe no avail

* setting tooltip color to match base color of surrounding text

* Restore weirdly changed snapshots curious if CI browser tests pass

* [WNMGDS-2875] Fix Release script take 2 (#3205)

* Export vars and function needed in release script

* Reorder imports and add new reviewers

* Add new utility functions used by bumpVersions

* Handle staging files properly

* Export correct function from versions

* export readJson so maybe we capture new line with read file'
'

* big refactor add comments break up inline for loop and associated functions

* Wrap removal of top level package json in try catch and uncomment woopsie

* Add maybe more helpful comment

* Further refactoring

* Looks like a big refactor but basically moved all code to a new file

* Adding functionality so we don't lose newline at end of json files

* [NO-TICKET] Automatically format json files (#3206)

* Run prettier on json files

* Update lint-staged config to format json files

* Undo new line addition when writing json

* Fix typo

* Move version number into our main function to make usage clearer

---------

Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>

* Undoing accidental hover styling change

---------

Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>

* Revert "Updating snapshots"

This reverts commit fd0f3bc.

* Addition of tabble and new content

* Added content and table

* Fixed table and aria labels

---------

Co-authored-by: Tamara deMent (Corbalt) <tamara@corbalt.com>
Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>
Co-authored-by: Kim Niedermaier <kimniedermaier+cmsds@navapbc.com>
@kim-cmsds kim-cmsds modified the milestones: 11.0.0-beta.1, 11.0.0 Sep 18, 2024
kim-cmsds added a commit that referenced this pull request Sep 18, 2024
update v11 blog post to remove reference to removing the privacy settings dialog
@kim-cmsds kim-cmsds deleted the kniedermaier/no-ticket/update-v11-blogpost branch September 26, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Documentation Indicates that this item relates to documentation Type: Fixed Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants