Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth token cookie does not have an expiration #1756

Closed
2 tasks
mgwalker opened this issue Aug 7, 2019 · 0 comments · Fixed by #1776
Closed
2 tasks

Auth token cookie does not have an expiration #1756

mgwalker opened this issue Aug 7, 2019 · 0 comments · Fixed by #1776
Assignees
Labels
bug needs triage, then squashing Development Issues for the dev team resolve sev3 Experience is flawed but not unusable.

Comments

@mgwalker
Copy link
Contributor

mgwalker commented Aug 7, 2019

When the API creates and sets the auth token cookie, it does not set an expiration. The result is that the browser creates a "session cookie," which causes it to be deleted when the browser is closed. (Session cookies can be deleted prior to the browser being closed as well; the exact circumstances are kind of unpredictable based on the browser, but closing the browser will always do it.) The result is that users can be logged out by closing their browser, rebooting their computer, etc.

One question is whether this is the desired behavior. I don't have a strong opinion either way. There's a security argument in favor of session cookies, but there's a convenience/usability argument for longer-lasting cookies.

This task is done when either...

  • closed because it works as expected OR
  • the cookie has an appropriate expiration set
@mgwalker mgwalker added bug needs triage, then squashing Development Issues for the dev team resolve labels Aug 7, 2019
@jeromeleecms jeromeleecms added the sev3 Experience is flawed but not unusable. label Aug 12, 2019
@mgwalker mgwalker self-assigned this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage, then squashing Development Issues for the dev team resolve sev3 Experience is flawed but not unusable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants