Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS][QPPSE-1710] Grant S3 CPC Bucket permissions to Codebuild service role #1412

Closed

Conversation

rajkpammi
Copy link
Contributor

@rajkpammi rajkpammi commented Feb 1, 2024

Information

  • Fixes #_
  • QPPSE-1710

Changes proposed in this PR:

  • Tf changes to allow access on s3 cpc buckets for codebuild iam service role
  • Added new env variable pertaining to s3 CPC buckets to match the naming convention on the buckets

Checklist

  • All JUnit tests pass (mvn clean verify).
  • New unit tests written to cover new functionality.
  • Added and updated JavaDocs for non-test classes and methods.
  • No local design debt. Do you feel that something is "ugly" after your changes?
  • Updated documentation (README.md, etc.) depending if the changes require it.

Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

"arn:aws:s3:::qppsf-codepipeline-s3-003384571330-us-east-1/*"
"arn:aws:s3:::qppsf-codepipeline-s3-003384571330-us-east-1/*",
"arn:aws:s3:::aws-hhs-cms-ccsq-qpp-navadevops-pii-cnvrt-npicpc-${var.s3cpcbucket_env}-us-east-1",
"arn:aws:s3:::aws-hhs-cms-ccsq-qpp-navadevops-pii-cnvrt-npicpc-${var.s3cpcbucket_env}-us-east-1/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajkpammi the other bucket should be aws-hhs-cms-ccsq-qpp-navadevops-pii-convrtr-audt-${var.s3cpcbucket_env}-us-east-1 right?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivaksb sivaksb closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants