increase test timeout for link checking #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kencheeto
requested review from
kalvinwang,
maripuncel and
samskeller
as code owners
kalvinwang
approved these changes
Aug 7, 2018
| @@ -28,7 +28,7 @@ function checkUrl(s) { | |||
| // this will run once a day on travis | |||
| if (process.env.TRAVIS_EVENT_TYPE === 'cron') { | |||
| it('has valid specification links', function() { | |||
| this.timeout(8000); // 8 seconds timeout. | |||
| this.timeout(12000); // 8 seconds timeout. | |||
There was a problem hiding this comment.
i would just delete the comment so it can't be wrong, it doesn't seem useful :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the test we merged recently to check that the measure specification links are valid failed because of a timeout, so I'm increasing the timeout here by 50%.
this test only runs on CI during cron runs, once a day.
failing run here:
https://travis-ci.org/CMSgov/qpp-measures-data/jobs/412016666