Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing setup #42

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

christianvluu
Copy link
Collaborator

@christianvluu christianvluu commented Feb 17, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Added an additional docker container for automated testing
  • Added additional automated testing docker container launch flag to ./setup_XXX.sh
  • Updated documentation
  • Split docker-compose files into difference launch cases (gpu + automated testing)
  • Set appropriate hostnames for docker containers
  • Connects the automated testing docker container with the autonomy docker container for ROS

QA Instructions, Screenshots, Recordings

  • Run ./setup.dev --run-testing
  • Go into autonomy docker (robobuggy2-main-1)
  • In another terminal window, go into tester docker (robobuggy2-tester-1)
  • Roslaunch the sim in the autonomy docker
  • In the tester docker --> Rostopic list or echo some topic from the autonomy docker
  • You should see topics being echoed over

Running ./setup_dev.sh without the --run-testing flag will NOT launch the automated testing docker container.

image

@christianvluu christianvluu marked this pull request as ready for review February 17, 2024 05:32
@Jackack
Copy link
Collaborator

Jackack commented Feb 17, 2024

Tested, works on Macbook Air.

@Jackack
Copy link
Collaborator

Jackack commented Feb 17, 2024

What's TEMP_DO_NOT_EDIT.txt

@christianvluu
Copy link
Collaborator Author

Temp requirements file bc docker requires them to be in the same directors per container. Figured it was kinda này to have the same file in two places so the setup scripts will copy them as needed from the root directory. Hence they are ignored by git and overwritten each time the container is spooled up.

What's TEMP_DO_NOT_EDIT.txt

@christianvluu
Copy link
Collaborator Author

^^ see line 82 onwards in setup dev for instance.

@maya-doshi
Copy link
Collaborator

It works for me on Fedora 39.

I had to make some fedora specific changes (These aren't important for the current merge though)

  • Replace all docker compose with docker-compose
  • sudo chcon -Rt svirt_sandbox_file_t ./r b_ws to allow folder access with SELinux active. (There was a way to fix this through the docker compose file iirc)

@christianvluu christianvluu merged commit 307eb63 into main Feb 17, 2024
3 checks passed
@christianvluu christianvluu deleted the sw/automated_testing_docker_setup branch February 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants