added preroll checks and publish check status #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also add your PR comments, I have no idea what I'm supposed to be checking for without actually digging into the code. |
|
Looks fine to me, haven't tested it myself so I'll defer to Jack for the approval. |
|
Might have to remove the RTK status check since I didn't realize that topic is not active in sim when I requested the check |
Jackack
requested changes
Feb 26, 2024
Jackack
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(stole format from patricks pr)
What type of PR is this? (check all applicable)
Description
Added additionally safety checks to autonsystem which will ensure messages are being received, RTK status is fixed, covariance is acceptable, and heading is pointing generally in the correct direction (within 180 degrees of where is should be)
QA Instructions, Screenshots, Recordings
The code still builds but hasn't been tested on the actual buggy.