Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made during mock rolls, debugging sessions that need to be preserved #47

Merged
merged 30 commits into from
Mar 13, 2024

Conversation

Jackack
Copy link
Collaborator

@Jackack Jackack commented Mar 5, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This branch contains utilities for mock rolls and debugging, fixes for minor bugs discovered during mock rolls, as well as adjustments to auton parameters.

Fixed minor bugs in launch files.
Added launch files and nodes for debugging auton overtake, filter separation and firmware steering.
Added path files for the cut and UC to purnell footpath.
Set debug to true in INS parameters.
Adjusted MPC path index search range.
Added exception in MPC and Stanley when the buggy reaches the end of the path.
Changed topic names to be consistent with firmware

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

This branch has been tested in mock rolls up to the commit where the current main branch was merged. Changes made during and after the merge are not tested in mock rolls.

Tests performed and passed pre-merging:

  1. run debug_filter.launch to check if the topic "/gnss_odom_distance" reports separation between the front antenna and the filter estimate. (requires going outside with SC)
  2. run debug_steer.launch to check if the topic "/SC/buggy/input/steering" has an oscillating pattern (plot on Foxglove).
  3. run main.launch with NAND_exist = false and roll the buggy.
  4. run ghost_auton.launch with path=UC_to_purnell.json, start the buggy in front of UC courtyard and check if the buggy avoids the ghost NAND.

In order to full test this PR, these tests should be repeated during a Mock Roll.

Jackack and others added 29 commits November 27, 2023 11:38
…ctory from __init__ parameter of trajectory.py
more pylint fixes

pylint fixes for 2d sim and other existing modules

pylint fixes yet again

pylint fixes yet again #2
Co-authored-by: Mehul Goel <mehulgoel873@users.noreply.github.com>
Co-authored-by: TiaSinghania <TiaSinghania@users.noreply.github.com>
Co-authored-by: PatXue <PatXue@users.noreply.github.com>
Added more mock roll paths and starting poses

expanded MPC traj index search window
fixed typo in publish_rtk_err.py variable naming
Copy link
Collaborator

@christianvluu christianvluu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t know enough about topic names and changes to that but looks good otherwise

@Jackack Jackack merged commit 26935a2 into main Mar 13, 2024
3 checks passed
@Jackack Jackack deleted the MockRoll branch March 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants