-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes made during mock rolls, debugging sessions that need to be preserved #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory from __init__ parameter of trajectory.py
more pylint fixes pylint fixes for 2d sim and other existing modules pylint fixes yet again pylint fixes yet again #2
Co-authored-by: Mehul Goel <mehulgoel873@users.noreply.github.com> Co-authored-by: TiaSinghania <TiaSinghania@users.noreply.github.com> Co-authored-by: PatXue <PatXue@users.noreply.github.com>
Updated sim launch file
Added more mock roll paths and starting poses expanded MPC traj index search window
fixed typo in publish_rtk_err.py variable naming
christianvluu
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t know enough about topic names and changes to that but looks good otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This branch contains utilities for mock rolls and debugging, fixes for minor bugs discovered during mock rolls, as well as adjustments to auton parameters.
Fixed minor bugs in launch files.
Added launch files and nodes for debugging auton overtake, filter separation and firmware steering.
Added path files for the cut and UC to purnell footpath.
Set debug to true in INS parameters.
Adjusted MPC path index search range.
Added exception in MPC and Stanley when the buggy reaches the end of the path.
Changed topic names to be consistent with firmware
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
This branch has been tested in mock rolls up to the commit where the current main branch was merged. Changes made during and after the merge are not tested in mock rolls.
Tests performed and passed pre-merging:
In order to full test this PR, these tests should be repeated during a Mock Roll.