changed telematics to visualize nand position #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackack
requested review from
christianvluu,
mehulgoel873 and
TiaSinghania
and removed request for
christianvluu
TiaSinghania
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
After an update, the INS driver publishes SC's position as a NavSatFix, which can be visualized by Foxglove. Therefore, there is no longer a need for telematics.py to republish SC position as a NavSatFix. However, NAND's position does need to be republished in order for it to be visualized
QA Instructions, Screenshots, Recordings
Run auton on SC with NAND communicating to it. Check on foxglove is NAND position is correctly displayed.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.