Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct teensy port name for NAND #69

Merged
merged 12 commits into from
Apr 1, 2024
Merged

Set correct teensy port name for NAND #69

merged 12 commits into from
Apr 1, 2024

Conversation

PatXue
Copy link
Collaborator

@PatXue PatXue commented Mar 28, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Change ros_to_bnyahaj.py to take in a --teensy_name argument, since the name of the teensy port on NAND is different from SC.

QA Instructions, Screenshots, Recordings

Test by running on NAND

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: Need to test this on actual NAND
  • I need help with writing tests

@Jackack Jackack merged commit 130846b into main Apr 1, 2024
3 checks passed
@Jackack Jackack deleted the nand-launch-file branch April 1, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants