Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM + CommonJS. Hybrid library! #21

Merged
merged 3 commits into from
Mar 11, 2022
Merged

ESM + CommonJS. Hybrid library! #21

merged 3 commits into from
Mar 11, 2022

Conversation

bartholomej
Copy link
Member

ESM + CommonJS + Types.

@bartholomej
Copy link
Member Author

@YuukiToriyama
This is a brand new version that supports both modern ES modules and classic CommonJS.
Everything should be backwards compatible, but I would still like someone else to verify that the library works in a real environment.

Could you confirm that version v1.0.0-next.6 works in your case too.

Thanks!

@YuukiToriyama
Copy link
Contributor

@bartholomej
It’s great to see you again.
It looks like a very nice work!
I'll do it later as soon as possible!

@YuukiToriyama
Copy link
Contributor

I am sorry for making you wait for a long time.

It seems good for my case! Completely compatible!

@bartholomej bartholomej merged commit c41c8a8 into master Mar 11, 2022
@bartholomej bartholomej deleted the esm-hybrid branch March 11, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtyemnyak davidtyemnyak davidtyemnyak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartholomej @YuukiToriyama @davidtyemnyak