Fix logspace regression in aln-based salmon

COMBINE-lab · Jun 13, 2015 · 3c797d1 · 3c797d1
1 parent 75095f2
commit 3c797d1
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/SalmonQuantifyAlignments.cpp b/src/SalmonQuantifyAlignments.cpp
@@ -404,8 +404,14 @@ void processMiniBatch(AlignmentLibrary<FragT>& alnLib,
 
                     // EQCLASS
                     TranscriptGroup tg(txpIDs, txpIDsHash);
+                    double auxProbSum{0.0};
                     for (auto& p : auxProbs) {
-                        p -= auxDenom;
+                        p = std::exp(p - auxDenom);
+                        auxProbSum += p;
+                    }
+                    if (std::abs(auxProbSum - 1.0) > 0.01) {
+                        std::cerr << "weights had sum of " << auxProbSum
+                                  << " but it should be 1!!\n\n";
                     }
                     eqBuilder.addGroup(std::move(tg), auxProbs);