Make _atom_type.element_symbol the enumeration default on some data items
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaitkus
reviewed
Jun 1, 2023
This reverts commit 8b31fc8.
vaitkus
approved these changes
Jun 3, 2023
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
jamesrhester
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #401
Dataitems done in this commit:
atomic_numberatomic_massradius_bond_atom_type.symbolis ambiguous #378length_neutrondispersion_real_cu,dispersion_imag_cudispersion_real_mo,dispersion_imag_moDataitems not being touched:
electron_countion_to_elementcromer_mann_a1--cromer_mann_chi_ang_fox_c0--hi_ang_fox_c3